Julian Geiger comments

Results 46 comments of


                                            Julian Geiger

trafficstars

Adding additional information to be shown with `verdi storage info --detailed`

Hi @ayushjariyal, I'm sorry I overlooked this and am just getting back here. Thank you for your contribution! I just rebased the PR to bring it to the current state...

Adding additional information to be shown with `verdi storage info --detailed`

Regarding the tests, there is a test of the `get_info` method (`test_get_info`) which is the only caller of the `get_orm_entities` method where you added your changes. Going through the callers...

Adding additional information to be shown with `verdi storage info --detailed`

@ayushjariyal, do you have time to work on this? Otherwise, I can also add the tests and we share authorship on the PR? Would like to wrap it up soon...

Adding additional information to be shown with `verdi storage info --detailed`

@danielhollas, maybe you can give this a quick review? Should be simple enough. While this is technically a new feature, and could go into 2.8.0, I think the changes are...

Adding additional information to be shown with `verdi storage info --detailed`

OK, change of mind. Moved this to 2.8.0. New feature, minor release. Let's follow SemVer properly...

Keyboard shortcut for code folding

Would also love this feature to be added. Having memorized the respective shortcuts from PyCharm, the possibility of assigning similar keybindings for code folding in JupyterLab would help a lot.