D Ruth Holloway

Results 9 comments of D Ruth Holloway

Note: I've got a patch for this coming, just adding some tests to t/app.pl to test that it works correctly. :smiley:

I have started this module, with two policies, ProhibitDeprecatedKeywords, and ProhibitUnrecommendedKeywords. It's available via CPAN now: [Perl::Critic::Dancer2](https://metacpan.org/pod/Perl::Critic::Dancer2). I'll be adding more later, and your recommendations/suggestions/pull requests are absolutely welcome!

I've added a policy, "ReturnNotNeeded", which handles superfluous returns. I also have additional ideas: - suggest `send_as JSON` instead of `return to_json` and similar constructs - Suggest Test::WWW::Mechanize::PSGI instead of...

I'd suggest making the change, and then giving it a try; make sure it passes all the tests, etc. But I'm all for being able to manipulate that data in...

I'm looking at `Dancer2::Core::Role::ConfigReader`, and it looks like `sub load_config_file` is where an include-directive handler would need to go--I'm willing to take a swing at this, if there's still a...

The conversation moved quite a ways from your original post, @yanick. It kinda pivoted into an enhancement idea for an "include" directive in D2 configurations just a few comments ago,...

I've pushed a commit that fills in some missing bits for the test state. These warnings were occurring when a 404 was reached, and the SERVER_PORT and SERVER_NAME were not...

that was my goof. I shorted out a bunch of other tests while I was working on the failures @xsawyerx had pointed out, and flat forgot to re-enable them. Fix...