Gavin Joyce

Results 68 comments of Gavin Joyce

@rwjblue is it just catchall routes that you want to ignore? If so, it would be nice if we could detect those and ignore (possibly by default, possibly by a...

@SeanSmithers Can you still reproduce this? I tried to in the branch, but it seems to work fine: https://github.com/intercom/ember-href-to/pull/22 Perhaps you could modify my branch to include an example of...

I think this may only be an issue in Ember 1.x. I can't reproduce it in ember 2.0. I'll confirm soon

@dongintercom thanks, that's useful. I'll use this to create a failing test and use that to fix the issue

@mazondo what version of ember are you using?

@yringler, thanks. Can you say more about what this is protecting against? When does the href-to document handler picks up and reacts to a click event when it shouldn't? Perhaps...

@johnunclesam 👍 that would be better. Perhaps you might be interested in submitting a PR?

> I was not sure how to write tests that pretend to be in an engine, suggestions are welcome. I'm not familiar with engines so I don't have any good...

We use the [rootURL](http://emberjs.com/api/classes/Ember.Router.html#property_rootURL) property on the `Router`, `href-to` is designed to work with this: ``` javascript var Router = Ember.Router.extend({ rootURL: '/a' }); ``` Perhaps one of these mechanisms...

Perhaps you could create a simple ember twiddle which demonstrates the problem? This would allow me to make a suggestion or a fix much faster