Gavin Joyce
Gavin Joyce
https://github.com/offirgolan/ember-cp-validations/pull/641 is 🍏. It drops support for decorators and supports all versions of ember from `2.16` -> `3.10`
Hi @dmcnamara-eng, thanks for this. Do you know if there an equivalent API to this in the React/Vue implementations?
Might be nice to create a helper named something like `component-or-element` to remove the need for a backing class in the `Menu::ItemElement` component: ```hbs {{#let (component-or-element @as) as |Tag|}} ```
Hmm, ^ might not be possible as the `element` helper is actually an AST transform, not a function that we can invoke: https://github.com/tildeio/ember-element-helper/blob/main/addon/helpers/element.js
A quick improvement might be to just create a `tag-name-is-component` helper, that will allow us to remove the need for a backing class
> do we have an RFC for an element helper? The https://github.com/tildeio/ember-element-helper readme references a couple of RFCs
👍 I think it's reasonable that top level components are public and any yielded components are private.
I don't remember the details. I seem to recall it was needed to keep parity with the Vue version, something to do with needing to have the flexibility of using...
👍 I'd be delighted to remove the `menu/item-element` if we can, it's a pretty ugly API.
Nice. It's possible that the Vue API changed since I last looked at it late last year. It's also possible that I made it more complex that it needed to...