Gary Osteen
Gary Osteen
I've run into this last week after I had to refactor to support visual regressions and multiremote style configs. I created a base config and then modify it for once...
Further testing shows this does not happen when you manually start the standalone jar before running the tests.
Interesting if that works. This might be acceptable for smaller projects, but when you have a large collection, this would slow things down a lot if you are use to...
Can anyone take some time to look this over?
@jmealo Thanks! I've always looked forward to giving back to open source eventually. I am elated to think that it might also fix some upstream issues!
@niftylettuce it is ready to go from code side. I don't know what else would be needed.
@3imed-jaberi I'm not sure I follow how it would make the update smooth. Logically the layer that gets added to pathOnly have no methods to match in the first place....
@jmealo pathOnly is used internally by Router.prototype.match which is a @private method. No outside project should be looking at that variable directly. The ctx.matched gets set at the same place...
I have a branch with fixes. I just need to figure out what I need to do to get permission to push to here.
I figured it out. First time contributing to open source. Learned a lot.