HybridDetect icon indicating copy to clipboard operation
HybridDetect copied to clipboard

Merge changes from LibXPUInfo

Open elpalmer opened this issue 1 year ago • 3 comments

  • Cross-platform enhancements
  • Clean build with MSVC x64 /W4 /WX

elpalmer avatar Sep 23 '24 16:09 elpalmer

Hi @elpalmer I made a change so I could compile on windows, can you verify that my change is ok before I merge?

MarissaDuBois-Intel avatar Sep 23 '24 23:09 MarissaDuBois-Intel

Hi @elpalmer I made a change so I could compile on windows, can you verify that my change is ok before I merge?

HI @MarissaDuBois-Intel , that change defeats the purpose of my change to make it build with /WX /W4 as required by SDL. I think I see the issue, though, and I will push another change for you to try.

elpalmer avatar Sep 24 '24 12:09 elpalmer

@MarissaDuBois-Intel Please review latest change.

elpalmer avatar Sep 24 '24 12:09 elpalmer

Code changes reviewed, tested, and approved.

MarissaDuBois-Intel avatar Sep 27 '24 16:09 MarissaDuBois-Intel