Adrián Chaves

Results 122 issues of Adrián Chaves

I realized this was worth doing while working on https://github.com/scrapy/scrapy/pull/5528, but I thought it best not to make it part of that pull request. I consider it a (minor) bug...

It would be great if a plugin like https://github.com/scrapy-plugins/scrapy-playwright did not had to force you to drive all requests through its download handlers, and instead you could drive certain requests...

enhancement
discuss

Calling https://github.com/scrapy/scrapy/blob/bbfa185664cef79299b48cb0ae22065439bb07fc/scrapy/utils/misc.py#L144 with a crawler is needlessly verbose: ```python create_instance(objclass, settings=None, crawler=crawler) create_instance(objclass, settings=crawler.settings, crawler=crawler) # functionally identical ``` It would be great if we could support a shorter alternative:...

discuss
cleanup

It is never called because request_seen() always returns False

discuss
cleanup

A minor cleanup for the future. At the moment [we use this in `http11.py`](https://github.com/scrapy/scrapy/pull/4897/files/2eabfb60e8112a85f4f1c6ce16c4a789856e3ead#r578344512): ``` with suppress(AttributeError): txresponse._transport._producer.loseConnection() ``` [Once we drop support for Twisted < 18.4.0](https://github.com/twisted/twisted/commit/38559237ec584e41d2c8667c3b9573865ddff19e), we should be...

cleanup

https://github.com/scrapy/scrapy/pull/4524#discussion_r477515464

enhancement

https://github.com/scrapy/scrapy/issues/5226#issuecomment-897621867

cleanup

- Add a new ``scrapy.spiders.ignore_spider`` decorator. The default spider loader ignores classes with this decorator. - Add a new ``SPIDER_LOADER_REQUIRE_NAME`` boolean setting. When ``SPIDER_LOADER_REQUIRE_NAME`` is ``True``, the default spider loader...

Currently, the HTTP compression middleware sets the `Accept-Encoding` header to `gzip,deflate` or `gzip,deflate,br` depending on whether or not [brotlipy](https://pypi.org/project/brotlipy/) is installed. However, if the user manually sets the `Accept-Encoding` header...

enhancement
good first issue