Leo Gall

Results 21 comments of Leo Gall

For the above mentioned chaotic models, I cut the CSV files manually and added a Markdown note to the reference folders: BevelGear1D https://github.com/modelica/MAP-LIB_ReferenceResults/blob/13debd9819062ea6ecc321538780f50717c11467/Modelica/Mechanics/MultiBody/Examples/Rotational3DEffects/BevelGear1D/readme.md GearConstraint3 https://github.com/modelica/MAP-LIB_ReferenceResults/blob/13debd9819062ea6ecc321538780f50717c11467/ModelicaTest/MultiBody/Parts/Rotor1D/GearConstraint3/readme.md

There is an implementation now by @pstelzig https://github.com/pstelzig/DateTime I did not test it, yet. I think this is a potential feature for MSL? @casella

Removed aD_Converter.y, dA_Converter.vout and dA_Converter.y from the list of comparison signals. Would be better to be able to define a specific tolerance _per variable_ for comparison. Possible workaround: Add a...

Currently simulation fails for: ModelicaTest.Fluid.TestComponents.Vessels.TestSimpleTank Maybe also because of tighter tolerance? Did not investigate, yet. `Failed condition: tank.medium.T >= 272.15 and tank.medium.T

ModelicaTest.Fluid.TestComponents.Fittings.TestJunctionTraceSubstances did not indicate " @GallLeo please generate reference file." But, according to the analysis, I also updated the reference. Is that OK @casella?

Regressions not mentioned in this ticket: 1. Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator 2. Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_NoLoad Should they also get new references @AHaumer ? Current comparison report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica/testrun_report.html

> Regressions not mentioned in this ticket: > > 1. Modelica.Electrical.Analog.Examples.OpAmps.SignalGenerator > > 2. Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_NoLoad > > > Should they also get new references @AHaumer ? > > Current comparison...

> > @GallLeo Please add the appropriate labels for library and version. > > I'm a bit lost. What is the error? Clicking on the links just give a bunch...

> The [regression report](https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica/testrun_report.html) looks good now on Modelica.Blocks. > > @GallLeo there are three new examples in Modelica.Blocks.Examples: > > 1. Modelica.Blocks.Examples.DemoSignalCharacteristic > > 2. Modelica.Blocks.Examples.DemonstrateContinuousSignalExtrema > > 3....

> > The [regression report](https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/Compare/Modelica/testrun_report.html) looks good now on Modelica.Blocks. > > @GallLeo there are three new examples in Modelica.Blocks.Examples: > > ``` > > 1. Modelica.Blocks.Examples.DemoSignalCharacteristic > > >...