ModelicaStandardLibrary icon indicating copy to clipboard operation
ModelicaStandardLibrary copied to clipboard
verified publisher icon modelica

MSL 4.1.0 Regressions - Electrical and ComplexBlocks

Open GallLeo opened this issue 1 year ago • 18 comments

The following models fail in result comparison. Tested revision: f9bddf86 (2024-02-16)

Changed models, need reference update after library officer check:

  • [x] Modelica.Electrical.Machines.Examples.ControlledDCDrives.CurrentControlledDCPM - Reason: Erroneous initialization of armatureInverter.iDCFilter has been fixed. @GallLeo pls. create new reference results. - Updated reference files?
  • [x] Modelica.Electrical.Machines.Examples.ControlledDCDrives.PositionControlledDCPM - Reason: Erroneous initialization of armatureInverter.iDCFilter has been fixed. @GallLeo pls. create new reference results. - Updated reference files?
  • [x] Modelica.Electrical.Machines.Examples.ControlledDCDrives.SpeedControlledDCPM - Reason: Erroneous initialization of armatureInverter.iDCFilter has been fixed. @GallLeo pls. create new reference results. - Updated reference files?
  • [x] Modelica.Electrical.PowerConverters.Examples.DCAC.PolyphaseTwoLevel.ThreePhaseTwoLevel_PWM - Reason: Bugfix in Modelica.Electrical.PowerConverters.DCAC.Control.SVPWM @GallLeo pls. create new reference results. - Updated reference files?
  • [x] Modelica.Electrical.PowerConverters.Examples.DCAC.SinglePhaseTwoLevel.SinglePhaseTwoLevel_R - Note: does not fail in csv-compare, but in integral check for inverter.ac.v - Reason: Changed formulation of comparison in Modelica.Electrical.PowerConverters.DCDC.Control.SignalPWM @GallLeo pls. create new reference results. - Updated reference files?
  • [x] Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.HBridge_R - Reason: Changed formulation of comparison in Modelica.Electrical.PowerConverters.DCDC.Control.SignalPWM @GallLeo pls. create new reference results. - Updated reference files?
  • [x] Modelica.Electrical.Spice3.Examples.Spice3BenchmarkFourBitBinaryAdder - Reason: Model has not been touched for ages, differences are neglectible. @GallLeo pls. create new reference results. - Updated reference files?
  • [x] Modelica.ComplexBlocks.Examples.ShowTransferFunction - Reason: Changed the parameters of the example to get more eye-catching results. @GallLeo pls. create new reference results. - Updated reference files?

Not classified yet, needs library officer check:

  • [x] Modelica.Electrical.Machines.Examples.InductionMachines.IMC_InverterDrive - Reason: Bugfix in Modelica.Electrical.PowerConverters.DCAC.Control.SVPWM @GallLeo pls. create new reference results. - Updated reference files?

  • [x] @GallLeo please note: We have improved the comparisonSignals.txt in PR #4353 of Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.{HBridge_R, HBridge_RL, HBridge_DC_Drive}, also back-ported to maint/4.1.x in #4372. Please create new reference results for all three examples.

  • [ ] Release notes check: Are all classes mentioned which could lead to result changes in user models?

Useful Links

Current comparison report: https://www.ltx.de/download/MA/Compare_MSL_v4.1.0/comparison_report_overview.html -> Reference result test -> Comparison

Comparison signal definitions: https://github.com/modelica/ModelicaStandardLibrary/tree/master/Modelica/Resources/Reference/Modelica https://github.com/modelica/ModelicaStandardLibrary/tree/master/ModelicaTest/Resources/Reference/ModelicaTest

Reference results: https://github.com/modelica/MAP-LIB_ReferenceResults

GallLeo avatar Feb 27 '24 08:02 GallLeo