Marco Ebert
Marco Ebert
Yes, sure, using an array would be breaking and I think the way you're implementing it right now is the best compromise. Maybe this can be converted to an array...
Sorry, I started another review (see the last comments above) and forgot to submit it. Apart from that the PR looks good. Thank you very much for your effort @slimm609!
Regarding the tests: Have a look into this [directory](https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/ci). This [manifest](https://github.com/kubernetes/ingress-nginx/blob/main/charts/ingress-nginx/ci/controller-custom-ingressclass-flags.yaml) could be a good starting point. I know we already changed the name of the property once. But what...
/kind feature /priority backlog /triage accepted /hold
/retitle Chart: Add alias `IngressClass` resources.
Closing this in favor of https://github.com/kubernetes/ingress-nginx/pull/11109. /close
/cherry-pick release-1.10
Dunno if I'm eligible for deciding or giving input on this, but first of all I'd like to tell that I proposed https://github.com/kubernetes/ingress-nginx/pull/9732 only for aligning the pod's labels to...
One more: Right now `isRunningMultiplePods` is bound to one using this Helm chart. Is this a requirement and the only supported way? Because otherwise one could also use their own...