ingress-nginx icon indicating copy to clipboard operation
ingress-nginx copied to clipboard

fixes brotli build issue

Open u5surf opened this issue 1 year ago β€’ 11 comments

What this PR does / why we need it:

brotli’s build issue had fixed a few minuites ago. Thus, we should revert the build script. https://github.com/google/ngx_brotli/issues/156

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] CVE Report (Scanner found CVE and adding report)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I've read the CONTRIBUTION guide
  • [ ] I have added unit and/or e2e tests to cover my changes.
  • [ ] All new and existing tests passed.

u5surf avatar Oct 09 '23 07:10 u5surf

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
Latest commit 9c7de6820da72885abb91136754df1316f7e3d50
Latest deploy log https://app.netlify.com/sites/kubernetes-ingress-nginx/deploys/65c214d717b85a0008548eee

netlify[bot] avatar Oct 09 '23 07:10 netlify[bot]

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 09 '23 07:10 k8s-ci-robot

Welcome @u5surf!

It looks like this is your first PR to kubernetes/ingress-nginx πŸŽ‰. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Oct 09 '23 07:10 k8s-ci-robot

Hi @u5surf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 09 '23 07:10 k8s-ci-robot

Thanks

tao12345666333 avatar Oct 10 '23 16:10 tao12345666333

/hold

Wait for @strongjz

tao12345666333 avatar Oct 10 '23 16:10 tao12345666333

can you rebase, we added a new test that does the nginx compile in GHA, if that passes then we can accept this PR.

strongjz avatar Oct 11 '23 12:10 strongjz

All tests have passed. I think we can merge this. cc @strongjz

tao12345666333 avatar Nov 13 '23 15:11 tao12345666333

Thank you for your contributions. The brotil build has been fixed in #10668.

I will do the rebase and we can decide if we need to change the depth.

➜  /tmp git clone --depth=1 https://github.com/google/ngx_brotli.git
Cloning into 'ngx_brotli'...
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (19/19), done.
remote: Total 21 (delta 4), reused 11 (delta 1), pack-reused 0
Receiving objects: 100% (21/21), 17.86 KiB | 281.00 KiB/s, done.
Resolving deltas: 100% (4/4), done.
➜  /tmp cd ngx_brotli 
➜  ngx_brotli git:(master) ls
config  CONTRIBUTING.md  deps  filter  LICENSE  README.md  script  static
➜  ngx_brotli git:(master) tree deps 
deps
└── brotli

2 directories, 0 files

tao12345666333 avatar Nov 22 '23 05:11 tao12345666333

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, tao12345666333, u5surf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 30 '24 15:03 k8s-ci-robot

/cherry-pick release-1.10

Gacko avatar Apr 01 '24 11:04 Gacko

@Gacko: new pull request created: #11187

In response to this:

/cherry-pick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.