Marco Ebert

Results 269 comments of Marco Ebert

Config: Do not log URL parameters.

So after letting this settle a bit and finding the time to have another look, I basically agree with this change. Ingress NGINX should be secure by default and not...

use a NodePort service as ExternalName in another service type ExternalName for configuring default-backend

I'd like to test this locally and therefore /hold this PR for now.

[discuss] fail annotation parsing fast and report errors as events

/cherry-pick main

[discuss] fail annotation parsing fast and report errors as events

/cherry-pick release-1.10

NGINX: Correctly determine client IP.

Hello @dmeremyanin, time. Just time. 😬 Sorry to say, but we currently are something between 2 and 3 maintainers also having a day to day job and still a lot...

NGINX: Correctly determine client IP.

/kind feature /priority backlog

NGINX: Correctly determine client IP.

I amended your issue description so merging this PR automatically closes the referenced issues.

NGINX: Correctly determine client IP.

/lgtm

NGINX: Correctly determine client IP.

/unhold

Turn off returning HTTP OK for /healthz endpoint during preStop hook to allow AWS NLB unhealthy draining

I didn't check it in a live cluster, but I'd expect Kubernetes to first set the pod terminating, meaning initializing the shutdown process, starting with pre stop hooks and what...