gudhi-devel
gudhi-devel copied to clipboard
GUDHI
The GUDHI library is a generic open source C++ library, with a Python interface, for Topological Data Analysis (TDA) and Higher Dimensional Geometry Understanding.
To be discussed, but magic methods should appear in Python documentation for the SimplexTree
While testing on a VM, it ends with: ```txt python -m delvewheel show .\dist\gudhi-3.8.0a0-cp310-cp310-win_amd64.whl Analyzing gudhi-3.8.0a0-cp310-cp310-win_amd64.whl The following DLLs will be copied into the wheel. msvcp140.dll (C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.30.30705\bin\HostX64\x64\msvcp140.dll)...
It looks like in numpy, `ravel` is very similar to `flatten`, except that it avoids doing unnecessary copies. I think all of our calls to `flatten` could be replaced.
## Problem When fixing [PR 836](https://github.com/GUDHI/gudhi-devel/pull/836#discussion_r1147929781), it has been discussed that some cmake generators (like visual studio) ignore CMAKE_BUILD_TYPE. ## Possible fix: The advice is to try and use generator...
Just like [read_points_from_off_file](https://gudhi.inria.fr/python/latest/point_cloud.html#gudhi.read_points_from_off_file), a `read_faces_from_off_file` function would be helpful
https://github.com/GUDHI/gudhi-devel/blob/f41c856d3ea0066fe0bcec2121506a7ca11301cc/src/Doxyfile.in#L703 looks for this file in one place, but https://github.com/GUDHI/gudhi-devel/blob/f41c856d3ea0066fe0bcec2121506a7ca11301cc/src/cmake/modules/GUDHI_user_version_target.cmake#L19 puts it in a different place. When I build the doc (and more) from a subdirectory with `cmake .. -DWITH_GUDHI_PYTHON=OFF...
`plot_persistence_density` is rather slow, because the density estimation takes a lot of time. For a grid 300x300 and 10000 points, it already takes about 10s with scipy, and more if...
The python user manual for the cubical complex was copied from C++ ("One can use various constructors from the file Bitmap_cubical_complex_periodic_boundary_conditions_base.h") and does not mention the new CubicalPersistence (at least...
https://github.com/GUDHI/gudhi-devel/blob/8266dc84888001f459d57425e1a31989046913e4/src/Simplex_tree/include/gudhi/Simplex_tree.h#L351 I notice that the move constructor and assignment of Simplex_tree are not marked `noexcept`. Is there a good reason for that? I didn't check in depth, but the reason...
In a cubical complex like this  whose filtration is computed from the top-dimensional cells, we do not need to consider all the cells to compute persistent homology. We can...