Garrick Cheung

Results 82 comments of Garrick Cheung

@rakesh5208 Sorry, I linked to the wrong PR in my comment but corrected it.

@vignesh20794 would you mind creating a repo to reproduce this issue? That would be very helpful to debug.

@rwwagner90 it is already achievable, but what I’m proposing is adding the globs as a default which reduces manual configuration and and improves performance for large apps out of the...

I was seeing this on 1.15.x with [email protected]. Looking into this some it looks like the router isn't setup yet, that's why `this._routerMicrolib` is undefined. `this._routerMicrolib` is setup in the...

Looking around some more, it looks like the [integration test](https://github.com/intercom/ember-href-to/blob/master/tests/integration/href-to-test.js) is setting up the router with: ```javascript beforeEach() { getOwner(this).lookup('router:main').setupRouter(); } ``` @GavinJoyce Is there a way to automatically setup...

@panthony I see. My project has a couple of components that use `href-to` so setting up the router in a `beforeEach` for their respective tests addressed the issue but I...

@GavinJoyce @jamescdavis any updates on this?

I've created PR #128 to just bump the Node.js version to 8 in `.travis.yaml`.

@aaxelb can you rebase? #128 was merged and should fix the Node.js version issue.

Is there any update or link to the dep graph work that @chadhietala did? I'm curious to see how it could be leveraged here.