Garrick Cheung

Results 82 comments of Garrick Cheung

@gandalfar thanks for the PR! Sorry for the delay. I'll review this week.

@jamiechong I agree with you. It would be helpful to have a map of all the events for each Foundation component so that action closures could be passed in.

I haven't looked into this too deeply but at first glance it sounds like `didReceiveAttrs` or an observer would be better suited.

@dchersey I'm interested in how you got it working. I have the options set, but things aren't working. I've filed a separate ticket: #25

How about cross-posting to http://www.github.com/embroider-build/embroider?

Another solution would be to change the inline loader script to a JS file that inserts the SVG. Below's example demonstrates: * Loading a deferred JS file, which is similar...

Recently I worked on an engine that uses svg-jar using the symbols strategy. The only way I could get svg-jar to work in an engine was to include the path...

Would https://www.npmjs.com/package/ember-css-modules be a contender?

I agree it would be nice to not have a hardcoded versions list. Some ideas I have off the top are: 1. At build time, read from npm/yarn info on...

@ChristopherJohnson25 In your `login-form.hbs` it may be helpful to see if you can access `this.validations`. One way to start checking is logging to the console. ```handlebars {{log this.validations}} ``` The...