Gabor Buella

Include guard uses identifier reserved for implementation.

2

This is not a bug, just a would-be-nice-to-have thing: The __JSMN_H_ identifier starts with two underscores, which is triggers a warning while compiling with -Weverything with clang ( no need...

Test fix - expect (null) instead of $(XX), and $(XX) instead of $(N) in some other places

9

Hopefully helps with #77 --- This change is [](https://reviewable.io/reviews/pmem/syscall_intercept/79)

Introduce signal intercepting example

5

It is a nice first attempt to demonstrate the idea, far from complete. To give it a try, start the dummy program which installs a signal handler: LD_LIBRARY_PATH=./examples LD_PRELOAD=libsignal_interceptor.so ./examples/signaller...

Fix conflict with code sanitizers (UBSAN, ASAN)

2

* Use UBSAN and ASAN when it is possible. The way UBSAN, ASAN do code instrumentation seems to be conflicting with syscall_intercept's syscall hooking. They insert syscall instructions to places...

Make sure the whole library is signal safe. Add tests with some signal related syscalls, at least these two: SYS_rt_sigaction, SYS_rt_sigreturn. Reevaluate the `nr == SYS_rt_sigreturn` special case in `intercept.c`.

The way valgrind does instrumentation seems to be conflicting with syscall_intercept's patching methods. This needs to be investigated -- probably it can be fixed. Run existing tests under valgrind when...

Make the number of ELF section headers being tracked dynamic, or just add a comment about the array size being dynamic. `Elf64_Shdr headers[0x10];` "magic number - pls, comment on why...

Add a test and or an example which uses vfork. Reevaluate the special case in intercept.c for `nr == SYS_vfork`.

common: s/NVML/PMDK/

3

This change is [](https://reviewable.io/reviews/pmem/pmemfile/443)

Suspended refs inode

3

This change is [](https://reviewable.io/reviews/pmem/pmemfile/419)