gatb-core icon indicating copy to clipboard operation
gatb-core copied to clipboard

Please tag release to allow compilation of minia

Open smoe opened this issue 3 years ago • 1 comments

Hello, I found https://github.com/GATB/gatb-core/commit/7cb8a48cc958f4266c74db57f02e937d583ba9b7 suggesting that this is synced with minia development, and indeed compiling minia with the latest release gives

/home/moeller/git/med-team/minia/minia/src/Minia.cpp:170:65:   required from here
/home/moeller/git/med-team/minia/minia/src/Minia.cpp:312:62: error: ‘class gatb::core::debruijn::impl::GraphUnitigsTemplate<128>’ has no member named ‘_nbSolidKmers’

It would be great if you would tag a new point release with this change (and maybe also mention this in the minia source tree).

Many thanks! Steffen

smoe avatar Feb 16 '21 15:02 smoe

Hi Steffen,

thanks for opening an issue for this! I have updated minia's github master branch. Could you try a fresh checkout and see if it works for you? it compiles fine on my end. Anyhow, if all fails, minia binaries are provided here for an up-to-date version, features-wise: https://github.com/GATB/minia/releases/tag/v3.2.4

best, Rayan

rchikhi avatar Mar 04 '21 14:03 rchikhi