Ulrich-Matthias Schäfer

Results 576 comments of Ulrich-Matthias Schäfer

@edison1105 can i somehow checkout this PR ins vue-sfc to test it easily?

@sadeghbarati what exactly should we test in that example? It seems to work just fine, right? I need more context

well it does work so i dont see anything bad with doing that. However, this is not the right place to discuss this!

@skirtles-code thank you for the in-depth feedback! You are right. I totally forgot about the RFC procedure and jumped the gun. If you want, I can take a step back...

@MatanBobi there you go https://github.com/testing-library/dom-testing-library/pull/1341 I wasnt able to run the tests because I hit an error. Details in the PR

@eps1lon I looked into it and this is a deadlock. I tried several combinations of pinned dependencies and got the tests to work eventually. But now `validate` fails. I really...

OMG I DID IT!!!! I had to commit the package-lock.json to convince the CI to install the correct versions. So not sure what to do with this. It would be...

@timdeschryver I reverted the commit of the package-lock and the ci is red again. So would love some help here. Clearly the CI does _something_ with the lock-file :D Also...

It seems like that there was a push to introduce a lockfile in 2020 already but Kent wanted the approval from one other maintainer (https://github.com/testing-library/dom-testing-library/pull/624#issuecomment-643260300). Maybe that could be you?...