Ulrich-Matthias Schäfer
Ulrich-Matthias Schäfer
@alexander-akait I saw that when I run the tests a lot of them fail - unrelated to my changes. What is that about?
@alexander-akait so there are 2 remaining issues: - chokidar doesnt allow undefined as options anymore and crashes (even tho the types allow it... I raised an issue but they dont...
@alexander-akait no your logic is not broken. It is usually totally acceptable to pass undefined options to functions because typescripts optional type is `{ foo?: string | undefined }`. Chokidar...
Yeah, mine: https://github.com/paulmillr/chokidar/pull/1396 Well since chokidar doesnt support globbing anymore, everything that touches globs, we have to test on our side. Or we just test how specific globs are correctly...
Then I will pull out the creation of the ignore functions into own units. The we can simply test those.
@alexander-akait I added tests for the glob matching and also added wrapper code to support chokidars weird behavior with undefined values. It can be removed once they make up their...
Not from my side
I maybe found an issue with negated glob patterns. I need to figure out if everything is alright before merge
@alexander-akait the problem i encountered was, that I was filtering out potential nested directories because i couldn't partially match glob patterns. The new idea is, to wrap chokidar and emit...
The problem with `ignore` in chokidar is, that it will ignore a directory and also all subdirectories. If you would rather go with watchpak, thats obviously a solution, too. However,...