Mateusz Kowalczyk

Results 98 comments of Mateusz Kowalczyk

Probably something like this enough, but as per #224 I don't really know how to update the tests etc... ```diff diff --git a/crate2nix/templates/Cargo.nix.tera b/crate2nix/templates/Cargo.nix.tera index 64f8403..73da725 100644 --- a/crate2nix/templates/Cargo.nix.tera +++...

I guess we don't want crate name but the dir name of the source... whichever, should be easy

I tired this today. First, I tried runCommand but then realised I should be using `tools.nix`. Sadly, even with populated `crate-hashes.json`, it seems that when crate2nix invokes `cargo metadata`, that...

I worked around this by setting meta.mainProgram to crateName unconditionally.

There is no urgency from my side. These issues are basically for your information only.

I was unable to reproduce any more crashes in that part of the code. I found multiple issues in tag parsers however. I will create a separate issue for that...

Sorry I lied, here's an input it will crash on, on master. [in2.txt](https://github.com/kamiyaa/ruiji/files/1289857/in2.txt) To replicate simply add ``` char* load_file(char *file_name) { FILE * pFile; long lSize; char * buffer;...

[id:000002,sig:06,src:000003,op:havoc,rep:2.txt](https://github.com/kamiyaa/ruiji/files/1253685/id.000002.sig.06.src.000003.op.havoc.rep.2.txt)

Here is a real input that you may get from a web server that still passes all the previous checks in the code: i.e. in this version I haven't changed...

According to https://curl.haxx.se/libcurl/c/CURLOPT_WRITEFUNCTION.html , curl does not null-terminate the output for you so it seems like a completely possible bug.