Benjamin
Benjamin
Another way to handle this PR would be to merge to alpha then close https://github.com/cardano-community/guild-operators/pull/1743
> Separate from the review comments already left, I don't believe using node-8.9.0 as the base is correct. The tags are intended to provide a static commit that can be...
> node-8.9.0 I believe node-8.9.0 is a branch and not a tag: https://github.com/cardano-community/guild-operators/tree/node-8.9.0 I would expect the tag to be attached to a release commit post PR merge. Maybe the...
Given the work done supporting docker builds on https://github.com/cardano-community/guild-operators/pull/1754 and the plans to skip the 8.9.x per https://github.com/cardano-community/guild-operators/pull/1747#issuecomment-2060371121 I believe the changes in this PR and it's target branch are...
> > Given the work done supporting docker builds on #1754 and the plans to skip the 8.9.x per [#1747 (comment)](https://github.com/cardano-community/guild-operators/pull/1747#issuecomment-2060371121) I believe the changes in this PR and it's...
> Hey @Fuma419 @TrevorBenson , when you get a few - would you be able to resolve conflicts on this PR (apologies for the back-and-forth we've had on support for...
this pipeline is failing on this command: docker build . \ --file files/tests/pre-merge/rockylinux-guild-deploy.sh-l.containerfile \ --compress \ --build-arg BRANCH=testing/node-8.9.1 \ --build-arg COMMIT=d2077[5](https://github.com/cardano-community/guild-operators/actions/runs/8773405898/job/24073606632?pr=1747#step:7:5)e \ --build-arg G_ACCOUNT=cardano-community \ --tag ghcr.io/cardano-community/pre-merge-rockylinux:guild-deploy-l_d20[7](https://github.com/cardano-community/guild-operators/actions/runs/8773405898/job/24073606632?pr=1747#step:7:7)75e I see an...
> this pipeline is failing on this command: > > docker build . --file files/tests/pre-merge/rockylinux-guild-deploy.sh-l.containerfile --compress --build-arg BRANCH=testing/node-8.9.1 --build-arg COMMIT=d2077[5](https://github.com/cardano-community/guild-operators/actions/runs/8773405898/job/24073606632?pr=1747#step:7:5)e --build-arg G_ACCOUNT=cardano-community --tag ghcr.io/cardano-community/pre-merge-rockylinux:guild-deploy-l_d20[7](https://github.com/cardano-community/guild-operators/actions/runs/8773405898/job/24073606632?pr=1747#step:7:7)75e > > I see an issues...
I implemented some logic ([9f8894b](https://github.com/cardano-community/guild-operators/pull/1747/commits/9f8894b07318bb68029ba1ce12e94331479c7c91) and [82dfc8a](https://github.com/cardano-community/guild-operators/pull/1747/commits/82dfc8a8bf6e80eb5736b265805c8a86d2115db6)) in the workflow that is failing. I was able to do some limited testing locally by: 1. Cloning the upstream, then adding the...
> > I implemented some logic ([9f8894b](https://github.com/cardano-community/guild-operators/pull/1747/commits/9f8894b07318bb68029ba1ce12e94331479c7c91) and [82dfc8a](https://github.com/cardano-community/guild-operators/pull/1747/commits/82dfc8a8bf6e80eb5736b265805c8a86d2115db6)) in the workflow that is failing. I was able to do some limited testing locally by: > > > > 1....