Fuad Hasibul Hasan

Search class to wrap internal data

1

As a continuation of standardizing the search method (next steps of #143), this wraps the search related particle state arrays inside this class. It includes the following tasks: - [x]...

Standardize trace_particle_through_mesh

1

- [x] Replace `ray_intersects_triangle` with `line_segment_intersects_triangle`. - [x] Standardize* the behavior of arrays used as parameters. - [x] Move `set_new_element` function inside the functor. - [x] Add `next_element` parameter that...

Pass elmArea as parameter

2

`elmArea` is computed using the function `measure_elements_real`. Users may want to cache the information and avoid computing it in every search. Note: `tol` is related to `elmArea` and I have...

Pass Tolerance to `trace_particle_through_mesh` Instead of Computing it Everytime

2

In the following segment of the [`trace_particle_through_mesh` function](https://github.com/SCOREC/pumi-pic/blob/a9f7f8ec2630d66e68178c9ffe51610f2de2c15e/src/pumipic_adjacency.tpp#L489-L491), the tolerance for search algorithms is computed based on the "minimum area" and it can be expensive. ```c++ const auto elmArea =...

Unit test for find_exit_face function

3

We discovered that the `find_exit_face` function in `pumipic_adjacency.tpp` should not work when the `useBcc` flag is `true`. A test case is added here to demonstrate the failed scenario. Briefly, [the...

In [`trace_particle_through_mesh` ](https://github.com/SCOREC/pumi-pic/blob/89bd5bafadece57e8de0296a1deb9d1452526d74/src/pumipic_adjacency.tpp#L461) or [`search_mesh`](https://github.com/SCOREC/pumi-pic/blob/89bd5bafadece57e8de0296a1deb9d1452526d74/src/pumipic_adjacency.tpp#L642), they take a parameter called [`elem_ids`](https://github.com/SCOREC/pumi-pic/blob/89bd5bafadece57e8de0296a1deb9d1452526d74/src/pumipic_adjacency.tpp#L463) which stores the current element the particle is located inside. But in some scenarios, it can be useful to...