Jason Frey
Jason Frey
For example prefer .to_sym over .intern. The existing preferred methods cop only works on collections.
https://github.com/blog/2178-multiple-assignees-on-issues-and-pull-requests?utm_source=twitter&utm_medium=social&utm_campaign=multiple-assignees Also verify that the current assignment isn't broken.
Example from one of my PRs: Some comments on commit https://github.com/Fryguy/manageiq/commit/d6ec1eeff40b6703205560431ee3144967836462 - :red_circle: Bad migration date: db/migrate/data/20160127210624_convert_configurations_to_settings_changes/broker_notify_properties.tmpl.yml
Check the specs directory (except spec/support/\* and spec_helper.rb) for new files that don't end in _spec.rb
Give a grace period of 10 minutes or so, so as not to attack to quickly.
RubocopChecker doesn't just do rubocop anymore and it's confusing. If we start adding enable/disable for specific linters as per #244 , then the naming is going to get more confusing.
When backporting it's probably better to keep the code in the same form as the original PR and not make any further changes. As such, we probably want to disable...