miq_bot icon indicating copy to clipboard operation
miq_bot copied to clipboard

Bad Migration Date checker checks non-ruby files when it shouldn't

Open Fryguy opened this issue 9 years ago • 2 comments

Example from one of my PRs:

Some comments on commit https://github.com/Fryguy/manageiq/commit/d6ec1eeff40b6703205560431ee3144967836462

  • :red_circle: Bad migration date: db/migrate/data/20160127210624_convert_configurations_to_settings_changes/broker_notify_properties.tmpl.yml

Fryguy avatar Apr 08 '16 19:04 Fryguy

This is because it does File.basename, which in this case gives broker_notify_properties.tmpl.yml, which of course has a bad migration date. Probable fix is to only look at files directly in db/migrate and not subdirs.

Fryguy avatar Jun 21 '19 20:06 Fryguy

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

miq-bot avatar Jun 11 '20 22:06 miq-bot