FriendLey
FriendLey
It seems that using the approach as you suggested doesn't work, In the `fetch_data` pipeline, certain places are hard-coded to the `Data` class, which leads to the following error: `ValueError:...
> @FriendLey thanks for the PR! I am currently reading the paper that you linked in the issue. It might take some time to review this, but be sure –...
> Thanks for all the updates so far! Could you please avoid rebasing or force-pushing this branch once review has started? When you rewrite commits mid-review, my comments go stale...
@rienath Thank you again for your valuable feedback. I've carefully implemented all your previous suggestions in this revision (please let me know if anything was inadvertently missed). The CI failures...
@rienath I have processed all the new comments. Please review them again when you are free.
> @FriendLey could you have a look at [this](https://github.com/ClickHouse/ClickHouse/pull/74193#discussion_r2104207460) converstation? @rienath I have corrected the description in the document, please review it when you are free.
> @FriendLey there is [a failing test](https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=74193&sha=ae9da286d3e371b40d576aeaed6f0ef7d15347c3&name_0=PR) in CI (`03458_numeric_indexed_vector_operations_bit_promote`). It looks like the result of `numericIndexedVectorToMap(numericIndexedVectorPointwiseDivide(vec_1, 2))` may be undeterministic as the test produces correct result in other runs...
@rienath The failed test has been fixed, please review this pr when you are free.
> @FriendLey thanks. Indeed, the test is green now. For my interest: how did `rhs.isEmpty()` check in `pointwiseAddInplace(...)` fix the issue with the `numericIndexedVectorPointwiseDivide(...)` function, which does not call the...