EINIER FREYRE CORONA
EINIER FREYRE CORONA
> Did you test it on Windows to make sure it does what you expect? Or did you just compile it? I just compile it , if the other previous...
I already run a lot of tests this morning on github Actions , that's why have the force pushes , i tested , update the code and delete the commits...
> I don't understand the question. Can you clarify what you mean? I Search on all LSP references for the function Status , and did not found any call 0...
Hi @WingLim , all the revision changes are applied
@mohammed90 , i think it's correct now , i tried to avoid create a new error object for pass arguments as zap.Error() , instead i used a zap.String() for simplicity...
@mohammed90 , The linters are failing because import caddy.Log on notify make a circular dependency with import notify on caddy module , thats why the first time i use log...
I understand , just go backward on the commit for these change , i wait for responses for other members or just rollback the commit ?
🤷♂️ if you import caddy module on notify and notify on module caddy you always get the error , you wanna delete the notify module ?
Why will use Zap library on the first place ? it's not better an simple use log/slog of the std library ????
> But anyway, I think it's fine that we just plainly log in this case because it should never actually happen unless we had bad code which uses an unsupported...