Fred K. Schott

Results 142 comments of Fred K. Schott

Tracked it down to this change, only happening on Windows: https://github.com/withastro/astro/pull/4162/files This may actually be a Vite bug, since the path itself looks incorrect and I don't think we generate...

Thanks for the investigation @bluwy! It sounds like @natemoo-re didn't have a specific reason to change to `/@id/...`, so the easiest fix would probably be to revert that one line...

LGTM! Love quick changes like this šŸ‘

Interesting! So it sounds like there might be two bugs here. If anyone can track this down further, that would be great. @tony-sull is our resident TS expert but he's...

I can reproduce this as well, however I only see one copy of react in your node_modules folder: @Mrahmani71 that also fixes it for me, which is wild! @natemoo-re anything...

@natemoo-re and I tracked this down to `packages/astro/src/vite-plugin-jsx/tag.ts` not understanding anything other than `export default function X` and `export function X`. If anyone likes working with Babel, this would be...

@annaahsu can you confirm that you're on the latest release of `astro` and `@astrojs/image`? We believe that this was fixed in the last release! cc @tony-sull to confirm

This all makes sense to me! Thanks for the investigation and the thorough PR. As Nate said in the issue I’d also want a +1 from out resident TS expert...

@natemoo-re anything that we can do here before v1.0 next week?