Fred K. Schott
Fred K. Schott
Can you include steps that I could reproduce, including code snippets that I can add to a Snowpack app to see this failure in action?
Great call, let's definitely support this. Is there a way to detect that you're in a WebExtensions environment? It could also make sense to do some simple automatic checks here,...
I'm on board with allowing the user to provide a custom `window.HMR_INVALIDATE` function, and then rewriting reload to: ``` function reload() { window.HMR_INVALIDATE ? window.HMR_INVALIDATE() : location.reload(true); } ``` Although...
HMR should be reloading on every update, can you share your console logs / what kind of `message: XXX` updates you're seeing?
Oh, I also wonder if this line is returning false in your electron environment: `const isWindowDefined = typeof window !== 'undefined';` Which would then cause our normal reload function to...
Thank you for the kind words!
@yyx990803 oh nice! For some reason I was under the impression that your HMR implementation leveraged Rollup internally, not sure why I thought that. Any interest on collaborating on this...
also lol where are all these 👍 reaction emojis coming from? 👋👋👋
Gotcha, yea I was aware of how you did event bubbling but curious how it compared to what we've implemented. But, I realize I also didn't provide much details about...
> This is supported in webpack's HMR, and in the past it's been useful in the cases of e.g. a global state store that can hot swap its sub modules....