Nikita Malyavin

Results 32 comments of Nikita Malyavin

> Should this be rewritten as something like ~Sql_cmd()= delete;? yes, and perhaps remove `virtual`?

Hmm I guess we can't do it @svoj. `g++ -

So our best bet as i see it is to make those assertions _NO_ASSUME. It seems that C++ requires a reachable destructor (even though we know it will not be...

@wong-github1 hello again! Please format the commit messages according to [Coding standard](https://github.com/MariaDB/server/blob/main/CODING_STANDARDS.md#git-commit-messages). Also a description of what is done is nice to have -- a jira server is always a...

No worries @wong-github1 , it's a part of a proccess. I will anyway review your pull request code appropriately!

@grooverdan maybe instead of gcc-style __attribute__, let's add MY_NONNULL macro to `my_compiler.h`?

Hello @Simoffsky! As the project is close to its final stage, it's time to reorganize your code, also covering @vuvova's request from #3354. Please move the triggers processing (and other...

Please also join all tests in a single file. Test execution time is a problem for us, as every test run has a significant latency. Note that we maintain 80...

@hp77-creator yes, please, make a single commit and rebase. Please mention in the commit what is implemented, and what is only tested. Also mention our approach to reduce the size...