MDEV-34391 Implement SET PATH statement

[wong-github1]

• [x] *The Jira issue number for this PR is: MDEV-34391

Description

Implement the SET PATH statement.

Release Notes

Implement the SET PATH statement.

How can this PR be tested?

mysql-test/mtr path_basic

Basing the PR against the correct MariaDB version

• [x] This is a new feature or a refactoring, and the PR is based against the main branch.
• [ ] This is a bug fix, and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

• [x] I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
• [x] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

[wong-github1]

ar Sorry..

My second commit's comment is "Fixed unit test failed and compilation warning. Note: I have cross-checked the operation with set names and set roles. Therefore, I decided to also remove the unit test in file, sp.test."

[FooBarrior]

@wong-github1 hello again!

Please format the commit messages according to Coding standard.

Also a description of what is done is nice to have -- a jira server is always a subject of the availability, and a commit message is always there.

I would suggest adding::

• A short definition, as in the ticket;
• Function section from the ticket;
• If it's a standard feature -- then a reference standard (Standard version, year, book, section.)
• MariaDB implementation details.

[wong-github1]

Hi @FooBarrior ,

Thanks for highlighted my commit message is not compliant to the coding standard. Sorry, I just realized that. I have just committed the message. Could you please review again? Thank you.

[FooBarrior]

No worries @wong-github1 , it's a part of a proccess. I will anyway review your pull request code appropriately!

[abarkov]

Hello.

SET PATH is an SQL standard feature to control the order of stored routines resolution.

This patch only implements the variable. But the variable value is not used during SP name resolution. Without that part it cannot be accepted.

[grooverdan]

@wong-github1 now that you have written the path resolution, can you include test cases for it?

If you could rebase, resolve conflicts, squash commit and force push to the same branch that would be appreciated too.

[wong-github1]

Hi @grooverdan ,

Noted, got it. I'm still working into these all. I'm still testing after fixed with the other unit test failed, comeback to you soon.

[wong-github1]

Hi @grooverdan ,

I have just rebased, resolved conflicts, squash commit and force push to the same branch.

[grooverdan]

Also note per the failed build links above that the embedded mode is failing to compile.

[wong-github1]

Hi @grooverdan ,

Thanks for the review comments.

I'm currently reworking, gathering info. and solving other unit test failures that don't occur on my local host. I will comeback to you shortly.

[wong-github1]

Hi @grooverdan ,

I have just completed all reworks. Could you help review again? Thank you :)

[wong-github1]

Hi @vuvova,

Thanks for your review comments. I have just completed all reworks. Could you help review again? Thank you :)

[vuvova]

Thanks. I will, but in February, after the release

[vuvova]

@wong-github1, shall I close this PR and use #3796 instead?

[wong-github1]

Hi @vuvova,

Sorry of late in reply. It's ok for me. However, I think need to get the confirmation from Rakuten Japan's Mr. Shiva.

[vuvova]

closed in favor of #3796