Fokko Driesprong
Fokko Driesprong
I think we're almost there. I marked it as a draft because it is still a bit dirty. For example, setting properties is still missing, and it had some rough...
Added a gazillion tests, hopefully, this will bump it up to 90%+. For the json API, we could also return only pydantic models, and we get an open-api for free...
@rdblue Fine by me, thanks for merging 👍🏻
Thanks for the review @rdblue 🙌
I got a working version using PyIceberg here: https://github.com/pola-rs/polars/pull/10375 > a datafusion based project [glardb](https://github.com/GlareDB/glaredb) recently added iceberg support. Looks like it may be easy to port their [datafusion logic](https://github.com/GlareDB/glaredb/pull/1382/files#diff-bad171d1c866bf306008c03e85840223b096d394c3f7ae61d2001e190026cf20)...
Hey @alexander-beedie, thanks for jumping in here. What kind of SQL interface are you thinking of? We're supporting SQL-like syntax for the expressions: ```python large_rides_in_march = tbl.scan().filter("dt >= '2023-01-01' and...
Can you try setting: ``` s3.path-style-access=true ``` This can be done on a catalog level: ```sh spark.sql.extensions org.apache.iceberg.spark.extensions.IcebergSparkSessionExtensions spark.sql.catalog.demo org.apache.iceberg.spark.SparkCatalog spark.sql.catalog.demo.catalog-impl org.apache.iceberg.rest.RESTCatalog spark.sql.catalog.demo.uri http://rest:8181 spark.sql.catalog.demo.io-impl org.apache.iceberg.aws.s3.S3FileIO spark.sql.catalog.demo.warehouse s3a://xx/ spark.sql.catalog.demo.s3.endpoint http://los.xxxx.com:9000...
> @Fokko Do we want to keep Tabular provider (if there might be future tabular specific behavior?) or should we deprecate the whole tabular provider in favor of apache-iceberg provider?...
@romsharon98 Sorry for being late to the party here, but this looks great! Thanks for picking this up 🎉
@eladkal That makes sense. It was not my intent to merge this without your approval, but just to indicate that there are no further comments on the Operator and Hook...