Fokko Driesprong

Results 217 comments of Fokko Driesprong

@henriquelsmti can you rebase? The CI has been fixed on master

@epkanol did you also run the Python tests: ``` + python lang/py/build/src/avro/tool.py rpcsend http://127.0.0.1:39837 share/test/schemas/simple.avpr echo -file share/test/interop/rpc/echo/foo/request.avro Traceback (most recent call last): File "lang/py/build/src/avro/tool.py", line 160, in sys.exit(main(sys.argv)) File...

There are RPC tests which do calls from different languages, among others from Python/Java/Ruby, to make sure that the different implementations are still compatible: https://api.travis-ci.org/v3/job/467201360/log.txt

Please rebase onto latest master to fix the CI.

Sad CI: ``` Scanning dependencies of target avrocpp_s [ 1%] Building CXX object CMakeFiles/avrocpp_s.dir/impl/Compiler.cc.o /testptch/unknown/lang/c++/impl/Compiler.cc: In function ‘void avro::addCustomFields(const NodePtr&, const Object&)’: /testptch/unknown/lang/c++/impl/Compiler.cc:299:53: error: in C++98 ‘kKnownFields’ must be initialized...

@spektom can you rebase against latest master?

I like this, what's the status?

Hey @jun-he We're thinking of doing a first Python release, and I would love to have this in as well. Would you have some time to dig into the comments?...

Thanks @jun-he looks great! Thanks! 🚀