Fokko Driesprong comments

Results 478 comments of


                                            Fokko Driesprong

Enhance `catalog.create_table` API to enable creation of table with matching `field_ids` to provided Schema

Thanks for the context yesterday, I was still noodling on it overnight. If I understand correctly (and please also share the video of you and @adrianqin; I must have missed...

Flink: Pre-create fieldGetters to avoid constructing them for each row

@fengjiajie Rerunning the failed tests 👍

Implement nan_value_counts && distinct_counts metrics in parquet writer

Just checking in @vaibhawvipul if you're still interested in adding this :)

Make And expression JSON serializable using Pydantic

@Aniketsy Thanks for working on this, but I think this one is problematic, since it relies on `BooleanExpression`. I think we need to fix the `LiteralPredicate` first

Make And expression JSON serializable using Pydantic

@Aniketsy Certainly, let me know if you run into anything 👍

Make And expression JSON serializable using Pydantic

I would recommend taking some inspiration from the `Or` operator: https://github.com/apache/iceberg-python/pull/2565 It can be pretty tricky with the `__new__` method being overridden

Make And expression JSON serializable using Pydantic

@Aniketsy Gentle ping!

Make And expression JSON serializable using Pydantic

Closing this in favor of https://github.com/apache/iceberg-python/pull/2784

Include `initial-default` and `write-default` in repr

These are the relevant lines: https://github.com/apache/iceberg-python/blob/ccaa15cf8ac1eb1202256d17efc9cf9d20723d20/pyiceberg/types.py#L343-L344 Right now we never show them, but it would be nice to conditionally include them in the repr when they are not-null.

How do I find if there is residual in the table scan/plan files?

Hey @maytasm Thanks for raising this. We don't have the [ResidualEvaluator](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java) today, but it would be great to add that. We can take inspiration from Java. The code that you're...