Make And expression JSON serializable using Pydantic
#2518
This PR addresses issue by making the And expression in pyiceberg.expressions fully JSON serializable using Pydantic.
- Added a unit test to verify correct JSON serialization of the And expression.
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions. Thank you !
@Fokko Could you please review these changes when you have time.
@Aniketsy Thanks for working on this, but I think this one is problematic, since it relies on BooleanExpression. I think we need to fix the LiteralPredicate first
@Fokko sure, I will wait till LiteralPredicate get fixed and then continue working on this.
@Fokko I think PR on LiteralPredicate is merged, please let me know if I can proceed on this.
@Aniketsy Certainly, let me know if you run into anything 👍
I would recommend taking some inspiration from the Or operator: https://github.com/apache/iceberg-python/pull/2565 It can be pretty tricky with the __new__ method being overridden
@Aniketsy gentle ping on this :)
@kevinjqliu Could you please take a look and help me understand why one of the tests is failing?
@Aniketsy could u try apply the same fix as the OR pr #2565
@Aniketsy Gentle ping!
Closing this in favor of https://github.com/apache/iceberg-python/pull/2784