Florob

Results 21 comments of Florob

I'm not as such opposed to splitting some modules off into separate standalone crates, if they are useful on their own. However, that is where I draw the line. I'd...

May I ask why you want this? This panic is effectively unreachable.

If you were able to reach that panic it is certainly a bug, which is however not solved by removing the panic. Also this code is not (supposed to be?)...

I've been out of the loop for most things Lua for a few years, so not sure how much I can help here. Judging by the discussion in #147 and...

Is there any kernel documentation concerning this? In my testing GPIOs do not revert to their initial state when the `LineHandle` is dropped. So at least the README's claim that...

> Regarding the specification, the `main` status code is only related to the command itself, not at all to any of the subcommands (eg. an error in a subcommand has...

Sure. I'm speaking of the assert in https://github.com/L-Acoustics/avdecc/blob/55ee7d072c6ec4511102a125592e5ad3534f4194/src/controller/avdeccControllerImpl.cpp#L5104-L5106 Which fires in the context of https://github.com/L-Acoustics/avdecc/blob/55ee7d072c6ec4511102a125592e5ad3534f4194/src/controller/avdeccControllerImplHandlers.cpp#L555-L563 where `gotError` can be true, while `updatedStatus` remains `SUCCESS`. Now that I look at the...

> It's a correct claim. Signaling a driver-specific busy error through the blocking interface is an oversight. I see this affects LPSPI ([example](https://github.com/imxrt-rs/imxrt-hal/blob/29df2d21ad03130d859c29dd97e87cf26c9a8abb/src/common/lpspi.rs#L691-L692)) and LPI2C ([example](https://github.com/imxrt-rs/imxrt-hal/blob/29df2d21ad03130d859c29dd97e87cf26c9a8abb/src/common/lpi2c.rs#L664)); let me know if...

embedded-hal 1.0 is going to require variant 1 for I2C, but either variant for SPI. Relevant text quoted below. I2C: ```markdown # Flushing Implementations must flush the transfer, ensuring the...

I think overall we can still do better: * `allowfullscreen` is standard and widely supported, no reason for dropping it * `seamless` apparently has absolutely no browser support, and has...