Nick

Results 591 comments of Nick

This should be clarified more precisely. Even if the DisconnectResponse provided an error code, I don't believe the platform will interpret it. Regardless it seems like it'll disconnect the service.

I would be interested in seeing how this may be used.

Is there an advantage to doing this? I would like to see if there's a use case for it.

I guess if it's slightly more efficient that would be neat, as long as the API doesn't change and tests succeed a PR would be appreciated.

So you're using a different set of gRPC APIs in your application?

At the moment we are not aligning with Cloud Logging dependencies, so it is possible to occasionally run into conflicts, like what happened in #29.

If you do support a list of parameters, would your annotation support a comma-separated list of args or an array primitive? `@ForIntent("Intent Name", "Param Name 1", "Param Name 2", ...)`...

You mean between "category" and "category.original"?

You mean the parameter names, or the names of the context?

I guess choosing either the first (exit early) or the last (replace) would be the primary expected way to do it. Or maybe throw an exception if not specific enough....