Gerhard Stöbich

Results 195 comments of Gerhard Stöbich

I think top Level await can be used but as far as I know it works only in ECMAScript module mode not for commonJs. I requires node.js 14.8 as far...

> I guess now span processors are expected to handle these async promises? We already have some users which have implemented custom span processors. I guess this is considered breaking...

@AWare What do you mean in detail with pre-runtime step?

Why is it needed to mark `@opentelemetry/instrumentation` as ESM? Is it needed only for our tests or also for production? I think datadog APM uses import-in-the-middle but I don't think...

If I understand this correct OpenTracing will never set a span on context but OpenTelemetry picks up parents only from context. Looks obvious that OpenTelemetry instrumentations will never use a...

> opentracing API passes parents around explicitly. they don't need to pick anything up from context because they're provided directly to startSpan so we should be able to match them...

> But I think `AsyncLocalStorage` API won't allow that We should avoid to use any APIs from a concrete context manager to ensure this stays portable to e.g. browser and...

> Since we have already released the interface stable without this, we can only add it as an optional property on the interface. Isn't this a semver minor change? I...

I only read the argument why it needs to be optional and I don't agree with this. New API is semver minor in my opinion. Looking into the linked spec...

Seems I read the wrong part in spec as above link points to `TracerProvider#forceFlush`. [`SpanExporter#forceFlus`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#forceflush-2) in turn is optional according to spec and therefore I think it's better to add...