Gerhard Stöbich
Gerhard Stöbich
Are async hooks really broken by using an ESM entry point? Clearly several async operations have been executed already at this time but usually noone relies that asyncId starts with...
Looks like the API needs to be extended to either configure a new sampler on an existing `Tracer` or to pass the sampler to use to `TracerProvider.getTracer()`.
Seems this is caused by electron is using NODE_MODULE_VERSION 69 now which lets NAN think that it's newer then Node.JS 11 which uses 67 but actually electron 4.0.5 is more...
see #840
Not sure if this is the root cause of the above assert but in https://github.com/nodejs/node/pull/14040 there was a significant change in async hooks API but it was not applied on...
Looks to me like a too old version of NAN (2.12.1) is used. Could you try with latest?
Some questions comes in my mind in this: V8 API changes frequently so which version of V8 API have you planned to shim here? What is the benefit of a...
Adding `if (env()->can_call_into_js()) {` around [this code](https://github.com/nodejs/node/blob/6ac55fa337b57cecf36602d0acc3da25ee82a589/src/env-inl.h#L223-L230) solves the async hooks problem but it seems there are other similar places where JS code is called but no longer allowed.
@codebytere It's a while that I had this in my debugger so can't remember in detail. But as far as I remmeber it's as @Qard said the state changes after...
Thanks for the info. I will take a closer look into the current codebase to get deeper into this. Would be nice to get hints if there are any docs/minutes/......