Gerhard Stöbich
Gerhard Stöbich
What is the benefit of `onEnding()` compared to pass the read/write span to `onEnd()`? Both are sync, both are called at the same time (within the `Span.End()` api). To my...
I think there are usecases for both variants * I might have two backends and enrich spans depending on the backend * I might want to enrich spans in general...
I'm still not really clear what the expectation of `disable()` is and if we can reach this target once we have it. I doubt we find a way to remove...
I agree `disable()` is not exactly the same as `enterWith(/undefined)` or `exit()`. Having an API to just remove the strong reference from the current active `AsyncContextFrame` but having no control...
@yurishkuro It's specified as part of the SDK but an instrumentation should usually have no need to access the SDK, they should only need the API. As of now having...
Javascript is dynamically typed and there is nothing like a build step to link together to an app. It's quite easy to create an app having an SDK and some...
I don't think it's intentional. There was simply noone to take the time to implement all these events.
http is a built in module and not ESM so besides ESM customization hooks it should be also possible to use old style monkey patching. Clearly all this approach to...
@joyeecheung sorry, seems my review was too late, was interrupted a few times. no major findings anyway.
@orgads Usually this goes automatically. First it will land on 23 and later on 22. In case cherry-picking this commit from main to the release branch fails for some reason...