Gerhard Stöbich

Results 195 comments of Gerhard Stöbich

It's the version of SDK which matters here, not the API version. One can provide timestamps to `start` and `end`. The span duration is calculated by endTime - startTime. If...

1.8.0 is like >=1.6.0. Only 1.7.0 was different. The [change](https://github.com/open-telemetry/opentelemetry-js/pull/3129) included in 1.7.0 solved the problem of drifting performance clock but it introduced problems for locations where timestamps were given...

You could use a simple wrapper or optional chaining (`trace.getSpan(context.active())?.setAttributes()`) to avoid the repeated verbose code. I wonder also a bit about your usecase. To my understanding spans should usually...

There are several instrumentations which use the existence of a span to decide if they should create a new span (option `requireParentSpan`). Refs: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/1343

The main problem with the loader API is that it is still experimental and it doesn't seem that this changes soon. The current limitations are severe, e.g. only one loader...

Another option to avoid the need for monkey patching / loader hooks would be to avoid creating speparate instrumentation packages. Instead integrate OpenTelementry API directly into the frameworks in question....

@astorm A while ago I ran across [this](https://dev.to/giltayar/mock-all-you-want-supporting-es-modules-in-the-testdouble-js-mocking-library-3gh1) which seems to be what you are looking for. But not sure if this fits current loader hooks or is based on...

Regarding loaders: There is a complete rework ongoing and it will take a while. [First step](https://github.com/nodejs/node/pull/37468) already landed on master and I assume it will break import-in-the-middle. There is a...

One may name it callback someone else names it function :o). I doubt that functions are old style and increase complexity in general. Depending on usecase a simple arrow function...

How should OTel know which span belongs to a request? What is the exact definition of a request in general (not just HTTP/GRPC/...)? You define in your code when some...