Gerhard Stöbich

Results 195 comments of Gerhard Stöbich

You changed a bit more then `prepareALS` - you changed also `doSomething` do `await` it. each `await` creates a a few promises and async operations. Only the call to `await...

Honestly speaking I don't know the use case here. Usually using `enterWith` is a bad idea and `run` should be used. `enterWith` was intended for situations where it is not...

The idea is to do the OTel init for the instrumentations in a separate file and preload it by using `-r` command line argument or via NODE_OPTIONS environment. This should...

I agree that something like `instrumentations-node-all` would be better then `auto-instrumentations-node`. But actually `all` is also not correct because there are instrumentations hosted somewhere else which are not included.

We did similar breaking renames in the past, e.g. `@opentelemetry/tracing` is now `@opentelemetry/sdk-trace-base` (it's interesting that the download numbers for the deprecated package are still quite high). Tends to result...

I think the download numbers for `@opentelemetry/auto-instrumentations-node` are currently lower as for `@opentelemetry/tracing` and friends at the time they were renamed. But we should for sure avoid to rename more...

This is because of the async nature of NodeSDK in case resource detection is done (which is the default). see [here](https://github.com/open-telemetry/opentelemetry-js/blob/experimental/v0.33.0/experimental/packages/opentelemetry-sdk-node/src/sdk.ts#L185-L188) It also happens on main thread. You can avoid...

Do you want to merge any data into ended spans? How do you identify/search these spans?

According to the spec resource is immutable. Also resource is shared across all spans and potentially across other signals like metric/logs. To me it looks like a quite problematic use...

I understand your usecase but as of now the [spec](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.14.0/specification/resource/sdk.md) is quite clear regarding resources are immutable. There were some attempts to change this but as of now that did...