Gerhard Stöbich

Results 195 comments of Gerhard Stöbich

Is this somewhat related to https://github.com/nodejs/node/pull/48528?

@dygabo I think test failures in https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/35851/ might be related to this PR. Please take a look (after Labor Day ;o))

As far as I know the `freestyle` test job runs all tests in a worker thread instead main. The tests you created and the usecase itself clearly states different behavior...

Seems to be a child process issue not async hooks. The `assert` checks the exit `code` given via the childprocess `close` event which is a `number` according to [docs ](https://nodejs.org/dist/latest-v21.x/docs/api/child_process.html#event-close)...

Isn't it needed to execute at least two http requests to the same server to see the diff between use of the dedicated agent versus the global agent?

@psj-tar-gz Linter complains about a few findings. A rebase to current master is maybe also a good idea.

Isn't the main idea of the diagnosics channel to have publisher and subscirbers as decoupled as possbile? Why should one subscriber decide that another subscriber is not getting an event?...

> The intent is not to interrupt other subscribers, it is to interrupt the publisher. For example, if you tried to `fs.readFile(...)` the `passwd` file it could throw some error...

> So if there were a `try...catch` in the loop and that the error would be rethrown (what happen if we have multiple ones) then, it would guarantee that all...

I still don't understand the usecase where this is needed. As a result I have the feeling this breaks the main idea of diagnostics channel to allow efficient _collection_ of...