Dan Caseley

Results 108 comments of Dan Caseley

I know an instance I'd like to use it in, but it wouldn't work yet anyway. I wanted to test that a cookie _wasn't_ returned from a simple request. I...

Let's park this. We can use chai's `.not` to solve this (if we choose to) much easier once #93 is done, which we're gonna solve properly after #92.

Does this fix the mocha vs IcedFrisby mismatch with timeouts? A trimmed version of my test: ``` describe('Our giant API', function(){ before(function(){ frisby.globalSetup({ request: { headers: { 'Content-Type': 'application/json; charset=utf-8'...

Let's hold off for now. I can get around it with a mocha commandline timeout of the timeout x retries, plus a little for processing. In my example above, I...

Thanks for the contribution @gwcgm1! Any chance you could add some unit tests for this? There's some good examples of passing/failing expects based on body around here: https://github.com/IcedFrisby/IcedFrisby/blob/master/test/frisby_mock_request.js#L1135

I've been looking at some similar missing coverage in [Coveralls](https://coveralls.io/github/IcedFrisby/IcedFrisby), and I'm starting to believe that the npm request package used under the hood guarantees body to never be null...

I've removed the need for this check in the `unit-test-coverage` branch. Definitely don't worry about it. In fact, you can remove the entire `isUndefined` check - as I said, it...

I've removed that check (included in PR #124, merging soon), and had a punt at some unit tests. I'm convinced of coverage, but might be a touch extreme, and might...

I'd love to! My skills aren't super-strong, but I'm certainly eager. Got a few more ideas for plugins I want to write too, having read that I can extend existing...

On the note about expectJSONTypes, I make heavy use of it, but it always feels "different" from other checks. How could we manage upgrades on existing installs where it's in...