Dan Caseley comments

Results 108 comments of


                                            Dan Caseley

Update protocol-support.html

Previewed via https://htmlpreview.github.io/?https://github.com/igniterealtime/Openfire/blob/c75ee1a4ff63f241a474ded14d9e0365e780514c/documentation/protocol-support.html - LGTM :+1:

Upgrade Jetty to 9.4.48.v20220622

Supersedes #1959 (if successful)

OF-2415: Allow empty plugins directory at boot time in Docker entrypoint

Rebased

OF-2415: Allow empty plugins directory at boot time in Docker entrypoint

Feedback applied

Fix for pub-sub message ordering issue

Added to issue tracker, here: https://igniterealtime.atlassian.net/browse/OF-2147

OF-2492 - mvnw fixes

That's probably a good test of our code being buildable away from CI :+1:

OF-2474: IP-based access control for the admin console

Rebased.

OF-2474: IP-based access control for the admin console

When trying to set an invalid IP address in the Admin console, the value returns the previous value rather than allowing me to correct it. Is this the same behaviour...

OF-2474: IP-based access control for the admin console

When using a proxy that passes the X-Forwarded-For, and `adminConsole.forwarded.enabled` is set, the page correctly shows the client IP address. When the proxy address is added to the blocklist, the...

OF-2474: IP-based access control for the admin console

That makes sense. I've confirmed that the help text shown on the page uses the correct client IP when `adminConsole.forwarded.enabled` is set to True. Is there an argument for making...