Kavin
Kavin
> These are already implemented, see the Frame class (iirc), they are just not used in the NewPipe app Isn't that the storyboards/in video preview?
I'm not sure if `Content-Length`, should be set since for example, what if `gzip/brotli` is being used by the downloader?
Please check the PR linked below for a test APK (https://github.com/TeamNewPipe/NewPipeExtractor/pull/488)
For Spotify, it would be worth using something like https://github.com/librespot-org/librespot-java or https://github.com/devgianlu/librespot-android but careful consideration is required: https://github.com/librespot-org/librespot-java#disclaimer
Was there any conclusion to what library to use? Should we go with the default Java API? I'd like to rework on this, one last time.
> Are there currently some performance problems that would warrant such a change and its developer overhead? Yes, currently in NewPipe's case, a minimum of 2 requests are made regardless....
I tried updating the mocks, but it appears to be unable to find some requests, anyone have any idea why this might be happening?
> I checked out this branch and reverted the bug fix, but the added test are still passing => The tests are testing the wrong thing. > > Since a...
Ok, I just figured that it doesn't happen in the search result, hence why the test was passing. To see this in action, open https://piped.kavin.rocks/c/vox and https://www.youtube.com/c/vox/videos and find this...
I'll do that tomorrow, I have to board a plane today!