Shen Yang

Results 74 comments of Shen Yang

> can we use the `respond_to with format` helper That's originally what I had planned. I was just trying to get a list of all the routes that made changes...

thanks I'll clean up the issue description too when I have a chance

That's not the complete list. Don't know when I'll have time to update it

I think we removed cypress

I think ~~one of the cookies is trying to store the CSV contents~~ but the cookies can only have a max size of 4096 bytes or under 4096 characters ![image](https://user-images.githubusercontent.com/8918762/139179443-e1d39054-256a-4720-9f7c-2e3a93ec070f.png)...

Ok I think it starts at line 21 of [`app/controllers/imports_controller.rb`](https://github.com/rubyforgood/casa/blob/main/app/controllers/imports_controller.rb) where an `exported_rows` message is being stored in the session. ![image](https://user-images.githubusercontent.com/8918762/139251017-04a817f6-3bb0-46b1-aafb-85e25c373841.png) And the `exported_rows` message comes from [`app/lib/importers/file_importer.rb`](https://github.com/rubyforgood/casa/blob/main/app/lib/importers/file_importer.rb) which concatenates...

~~Delete needs confirmation~~ ~~Use async notifier. Not enough space on the button~~

~Need an object checker for typecheck~

Add boolean column on patch note type for delete after deploy