Filippo Valsorda
Filippo Valsorda
This is great! One opinion on the color of the bike shed. I feel like surfacing the file handle as part of the error would be cleaner than returning a...
> Dupe of #20420. I think it's related but not a dupe. #20420 is about negotiating over the protocol _smaller_ individual records to reduce (the peer's) memory requirements. This is...
Thank you. Is there a response header for the retryAt time or some other way to acquire it?
I treated this as lower priority than the changes that would go in the release, but I am going to try to make the final tar.gz/zip reproducible.
It might be because I didn't follow the unsafe.{String,Slice}{,Data} proposals closely enough, but I feel like there's hidden context in the decision process here that would be worth linking to...
LGTM. Only returning serverAuth makes sense per #26624. One thing I'm worried about is that if we ever add a new constraint to `NSSCert`, code written against an old version...
I couldn't come up with anything more elegant than that, so yeah :)
I'm hitting this repeatedly on TryBots even if I'm rebased on latest master. https://storage.googleapis.com/go-build-log/d6a16255/linux-amd64-race_6d494f2b.log https://go-review.googlesource.com/c/go/+/460542
I had checked that it was more recent than the CL mentioned in https://github.com/golang/go/issues/58168#issuecomment-1426118796 but it's entirely possible I got confused, sorry about that! I re-rebased while commenting but then...
Indeed, TryBots passed, sorry for the noise!