Filippo Valsorda

Results 376 comments of Filippo Valsorda

Go's crypto/ecdsa is not deterministic, but it's also not resting the security of the private key on the quality of the randomness. We should update the docs. It uses `SHA2-512(priv.D...

Rebased and removed the creack/pty dependency. Opening a PTY pair is really just a OpenFile and a couple IOCTLs.

Test added! Testing -stdin would require a dependency on x/term or more IOCTLs and it didn't feel worth it.

Sweet, thank you for the reviews! Resolved the conflict, should be ready to merge.

> @FiloSottile you got a 10m pty testscript timeout on macos on 1.20 there, any idea what might have happened? it succeeded on macos on 1.19, so perhaps it's a...

Rebased and added a skip for https://github.com/golang/go/issues/61779.

As an interesting prior art to look at, there's dnscrypt_proxy's cloaking feature, which is what I am using at the moment and that I'd hope to replace with this. https://github.com/DNSCrypt/dnscrypt-proxy/wiki/Cloaking

I believe this should be fixed in age v1.1.0+. If not, please open an issue at https://github.com/FiloSottile/age.