testscript: import timeout behavior from stdlib

Open FiloSottile opened this issue 3 years ago • 2 comments

This uses the -test.timeout flag (or the Params.Deadline field) to send first SIGQUIT (to get a stack trace) and then SIGKILL to a stuck command. It's mostly imported from the current stdlib code, with tweaks to work around the lack of Deadline and Cleanup method access.

Jul 28 '22 12:07 FiloSottile

Did you somehow write this PR on top of an older master? GitHub reports conflicts :)

Jul 28 '22 14:07 mvdan

Ah yep, I did, I've been using this for a bit in my fork. I'll rebase.

Jul 28 '22 14:07 FiloSottile

Conflict resolved! :)

Dec 27 '22 00:12 FiloSottile

There are conflicts again, my apologies. We recently merged a regression in the -continue flag, and I forgot that this was in flight already. If you can fix them again, which should hopefully not be too hard, I'll make sure to review quickly.

Jan 13 '23 16:01 mvdan

Done!

Jan 13 '23 16:01 FiloSottile