FenixH
FenixH
I guess the builds break because I excluded the compiled theorafile-dependencies. Should I include them as well?
> Much appreciated contribution. > > Native binaries will have to be submitted to the Dependencies submodule. Will do. > > I haven't thoroughly reviewed the PR yet, but to...
The stuff mentioned above have been fixed now. Updating the dependencies repo will have to wait until later.
Ok, so I have now tested that it works on MacOS and Linux as well (x64). The libs are available in https://github.com/MonoGame/MonoGame.Dependencies/pull/152.
> Could you commit the submodule change so that the build can access de binaries? Which change did I miss? The compiled libs were commited and accepted.
Could the build error for Windows be related to the change of graphics device discard color for the debug mode?
> > > It seems so, some of tests are based on image comparison for testing rendering fidelity toward a target and assume the debug clear color. You're right. It...
> > > Hello @FenixH, you can now upgrade the dependencies submodule to get the mac fix, which should allow this PR to move forward. Thanks! Done.
I read somewhere that support for 32-bit was going to be dropped, so I did not compile 32-bit binaries. If needed I can do that as well. However, its been...
@randrade23 thanks for your review and improvements! Happy that you got some use out of it.